ian-Liaozy commented on code in PR #39161:
URL: https://github.com/apache/beam/pull/39161#discussion_r3553801543
##########
sdks/python/apache_beam/runners/interactive/interactive_beam_test.py:
##########
@@ -853,12 +853,12 @@ def test_compute_dependency_wait_true(self):
spy_wait.assert_called_with({pcoll2}, async_res2)
# Let pcoll1 finish
- async_res1.result(timeout=60)
+ async_res1.wait_for_completion()
self.assertTrue(pcoll1 in self.env.computed_pcollections)
self.assertFalse(self.env.is_pcollection_computing(pcoll1))
# pcoll2 should now run and complete
- async_res2.result(timeout=60)
+ async_res2.wait_for_completion()
Review Comment:
Done.
##########
sdks/python/apache_beam/runners/interactive/recording_manager.py:
##########
@@ -710,19 +718,13 @@ def task():
return async_result
def _get_pipeline_graph(self):
- """Lazily initializes and returns the PipelineGraph."""
- if self._pipeline_graph is None:
- try:
- # Try to create the graph.
- self._pipeline_graph = PipelineGraph(self.user_pipeline)
- except (ImportError, NameError, AttributeError):
- # If pydot is missing, PipelineGraph() might crash.
- _LOGGER.warning(
- "Could not create PipelineGraph (pydot missing?). " \
- "Async features disabled."
- )
- self._pipeline_graph = None
- return self._pipeline_graph
+ """Initializes and returns the PipelineGraph."""
+ try:
+ # Try to create the graph.
+ return PipelineGraph(self.user_pipeline)
+ except (ImportError, NameError, AttributeError):
+ # If pydot is missing, PipelineGraph() might crash.
+ return None
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
