robertwb commented on a change in pull request #13264:
URL: https://github.com/apache/beam/pull/13264#discussion_r518567211
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1069,6 +1069,23 @@ def dropna(self, axis, **kwargs):
preserves_partition_by=partitionings.Singleton(),
requires_partition_by=requires_partition_by))
+
+ # TODO(BEAM-XXXX): support @<local> in eval and query. Currently fails in
+ # proxy generation
Review comment:
Go ahead and create the jira. Can we give a better message if @ is in
the expression?
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -318,8 +318,8 @@ def wrapper(self, *args, **kwargs):
def maybe_inplace(func):
@functools.wraps(func)
- def wrapper(self, inplace=False, **kwargs):
- result = func(self, **kwargs)
+ def wrapper(self, *args, inplace=False, **kwargs):
Review comment:
This is dangerous, as it won't catch if inplace was passed as a
non-keyword argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
