robertwb commented on a change in pull request #13264:
URL: https://github.com/apache/beam/pull/13264#discussion_r518985674
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -318,8 +318,8 @@ def wrapper(self, *args, **kwargs):
def maybe_inplace(func):
@functools.wraps(func)
- def wrapper(self, inplace=False, **kwargs):
- result = func(self, **kwargs)
+ def wrapper(self, *args, inplace=False, **kwargs):
Review comment:
We shouldn't use this in places where we may need to pass args.
(Actually, if we're just passing a`*args`, we can't generally detect `inplace`
safely at all).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
