TheNeuralBit commented on a change in pull request #13264:
URL: https://github.com/apache/beam/pull/13264#discussion_r518970400
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -318,8 +318,8 @@ def wrapper(self, *args, **kwargs):
def maybe_inplace(func):
@functools.wraps(func)
- def wrapper(self, inplace=False, **kwargs):
- result = func(self, **kwargs)
+ def wrapper(self, *args, inplace=False, **kwargs):
Review comment:
That could happen only with methods where the first kwarg is `inplace`
right? I wouldn't think there's many of those but I suppose there could be.
So what's the right thing to do here? We could use inspect to find `inplace`
in the args/kwargs of `func` and handle it correctly. Or more simply just never
use this in methods where we need to pass through args.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
