TheNeuralBit commented on a change in pull request #13264:
URL: https://github.com/apache/beam/pull/13264#discussion_r519071372
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -318,8 +318,8 @@ def wrapper(self, *args, **kwargs):
def maybe_inplace(func):
@functools.wraps(func)
- def wrapper(self, inplace=False, **kwargs):
- result = func(self, **kwargs)
+ def wrapper(self, *args, inplace=False, **kwargs):
Review comment:
If we passed the base type as in populate_defaults we could inspect it's
method. Seems like a lot of trouble.. but I'm just worried that there's some
edge case where we're dropping non-keyword args, and it would be great to catch
that possibility at import time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
