tvalentyn commented on a change in pull request #14607:
URL: https://github.com/apache/beam/pull/14607#discussion_r621553275
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -760,6 +776,24 @@ private void addDisplayData(Step step, String stepName,
HasDisplayData hasDispla
List<Map<String, Object>> list = MAPPER.convertValue(displayData,
List.class);
addList(getProperties(), PropertyNames.DISPLAY_DATA, list);
}
+
+ private void addResourceHints(Step step, String stepName, ResourceHints
hints) {
+ Map<String, Object> urlEncodedHints = new HashMap<>();
+ PercentCodec codec = new PercentCodec();
+ for (Entry<String, ResourceHint> entry : hints.hints().entrySet()) {
+ try {
Review comment:
It doesn't seem to be new for Beam,
https://github.com/apache/beam/blob/8b7f0b994926981298eb8195b2af24c8f12cebee/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L500,
but I had to declare it a compile-time dep for dataflow runner module. It is
small (400kb jar) and unlikely cause versioning conflicts.
One thought is that if we ever get to have binary-valued hints, encoding
bytes directly will be easier. I notice though PercentCodec does not by default
encode '+' as '%2b', but I can configure that to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
