tvalentyn commented on pull request #14607:
URL: https://github.com/apache/beam/pull/14607#issuecomment-833843012


   > To clarify why this came up: we have some test that takes the pipeline 
options and tries to turn them back into cmdline args and then read them again.
   > 
   > So `null` gets serialized to the string `"null"` but I don't think this 
can be expressed in cmdline args. The translation wasn't that smart, so it put 
`--resourceHints=null` on the command line, and then that parses back as the 
JSON value `["null"]`. That's the real bug. But as long as we don't need null 
vs empty list, let's just do empty list.
   
   @TheNeuralBit also came across this and beat me to the fix: 
https://github.com/apache/beam/pull/14736.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to