tvalentyn commented on a change in pull request #14607:
URL: https://github.com/apache/beam/pull/14607#discussion_r621666279
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowingStrategyTranslation.java
##########
@@ -287,7 +288,8 @@ public static FunctionSpec toProto(WindowFn<?, ?> windowFn,
SdkComponents compon
FunctionSpec windowFnSpec = toProto(windowFn, components);
String environmentId =
Strings.isNullOrEmpty(windowingStrategy.getEnvironmentId())
- ? components.getOnlyEnvironmentId()
+ ? components.getEnvironmentIdFor(
+ ResourceHints.create()) // TODO: get this from elsewhere
Review comment:
Do we still need a TODO?
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowingStrategyTranslation.java
##########
@@ -287,7 +288,8 @@ public static FunctionSpec toProto(WindowFn<?, ?> windowFn,
SdkComponents compon
FunctionSpec windowFnSpec = toProto(windowFn, components);
String environmentId =
Strings.isNullOrEmpty(windowingStrategy.getEnvironmentId())
- ? components.getOnlyEnvironmentId()
+ ? components.getEnvironmentIdFor(
+ ResourceHints.create()) // TODO: get this from elsewhere
Review comment:
Do we still need the TODO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
