je-ik commented on pull request #14718:
URL: https://github.com/apache/beam/pull/14718#issuecomment-847200605


   c) has additional question about what the semantics of 
   ```java
   timer.set(window.maxTimestamp().plus(X))
   ```
   should be. Should it be 
`timer.withOutputTimestamp(window.maxTimestamp()).set(window.maxTimestamp().plus(X))`?
 Although I think it is semantically correct, my concerns are really about the 
backwards compatibility. And as mentioned - given the fact that we do not 
restrict timestamp of `outputWithTimestamp`, I think we should leave it 
entirely on the user to emit data with timestamp for some (future) window.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to