boyuanzz commented on pull request #14718: URL: https://github.com/apache/beam/pull/14718#issuecomment-846186615
Changes look good to me because it loosens existing conditions. But I have a question regarding to `outputTimestamp` and `fireTimestamp`. If we set a `watermarkHold` that is larger than the `fireTimestamp`, won't the timer never be fired? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
