kennknowles commented on pull request #14718: URL: https://github.com/apache/beam/pull/14718#issuecomment-847185865
It is OK to make a breaking change for such a new feature. It is also OK to make a breaking change when it is moving from "incorrect" to "correct". I think I am OK with b, c, or d. The problem with (d) is of course that the window may expire downstream and be GC'd, dropping the output data. I'm not totally sure about (b) if there is some way the data can be lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
