kw2542 commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r726214979
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
})
public class ReshuffleTranslation {
- static class ReshuffleTranslator implements
TransformPayloadTranslator<Reshuffle<?, ?>> {
Review comment:
@robertwb @je-ik are you suggesting that we keep Reshuffle itself as a
PTranform as well and continue register it?
IIRC, ReshuffleTranslation is used only for Java Pipelines, since we have
updated Reshuffle.of() to return Reshuffle.PerKey which is registered as the
new urn, there is no need for us to keep Reshuffle itself a PTransform with the
old urn anymore.
It is true that runners who are translating the old urn needs to be updated
in order to be able to recoganize and translate the new urn, however, I don't
think keeping the registration here helps. Am I missing anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
