kw2542 commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r726278201
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
})
public class ReshuffleTranslation {
- static class ReshuffleTranslator implements
TransformPayloadTranslator<Reshuffle<?, ?>> {
Review comment:
We can do that, couple of things to confirm:
1. it means `Reshuffle` and `Reshuffle.PerKey` will be two identical
composite PTransform with two different urns. When do you think we should be
able to remove `Reshuffle` later?
2. For existing tests which are using `Reshuffle.of()`, shall we update all
of them to use `Reshuffle.perKey()` instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
