je-ik commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r726237543



##########
File path: 
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
 })
 public class ReshuffleTranslation {
 
-  static class ReshuffleTranslator implements 
TransformPayloadTranslator<Reshuffle<?, ?>> {

Review comment:
       The registration should help runners, that do not recognize 
`Reshuffle.PerKey` to recognize the original `Reshuffle.of()`, or not? It 
depends on how is the runner implemented (mostly if it first replaces _known_ 
transforms and only after that does the expansion of composites).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to