je-ik commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r726296511
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
})
public class ReshuffleTranslation {
- static class ReshuffleTranslator implements
TransformPayloadTranslator<Reshuffle<?, ?>> {
Review comment:
Could we expand `Reshuffle.of()` into `Reshuffle.perKey()`? I'd remove
the URN for Reshuffle.of() once we remove the deprecated Reshuffle.of() method.
If we directly expand Reshuffle.of() into Reshuffle.perKey(), then I think
it would be possible to test the expansion and then replace all the occurrences
of Reshuffle.of() by Reshuffle.perKey().
@robertwb WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
