lukecwik commented on a change in pull request #15757:
URL: https://github.com/apache/beam/pull/15757#discussion_r733185343



##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -377,6 +381,9 @@ def push(hp, e):
     else:
       heap = []
       for bundle in bundles:
+        # See above.

Review comment:
       ```suggestion
           # TODO(robertwb): Remove once legacy dataflow correctly handles
           # coders with combiner packing and/or is deprecated.
   ```
   
   See above is likely to become vague.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to