lukecwik commented on a change in pull request #15757:
URL: https://github.com/apache/beam/pull/15757#discussion_r733202648
##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -365,6 +365,10 @@ def push(hp, e):
for element in bundle
]
continue
+ # TODO(robertwb): Remove once legacy dataflow correctly handles
Review comment:
The test passes because `list(iterable)` walks the entire `iterable`
loading it into memory as a `list` type. `list` type supports `len` and
`reverse`. I'm still unclear as to why the Dataflow deprecation will resolve
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
