TheNeuralBit commented on a change in pull request #15757:
URL: https://github.com/apache/beam/pull/15757#discussion_r733204622
##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -365,6 +365,10 @@ def push(hp, e):
for element in bundle
]
continue
+ # TODO(robertwb): Remove once legacy dataflow correctly handles
Review comment:
Right I understand this fix, but I'm saying that the same test that's
currently broken on legacy Dataflow is passing on Dataflow V2 at head, without
this fix. Presumably that's why the deprecation matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
