TheNeuralBit commented on a change in pull request #16541:
URL: https://github.com/apache/beam/pull/16541#discussion_r792243106
##########
File path: sdks/python/apache_beam/utils/processes_test.py
##########
@@ -48,11 +48,9 @@ def test_method_forwarding_not_windows(self, *unused_mocks):
processes.subprocess.check_call.assert_called_once_with(
['subprocess', 'check_call'], shell=False, other_arg=True)
- processes.check_output(['subprocess', 'check_output'],
- shell=False,
- other_arg=True)
Review comment:
Does this actually trigger the pylint check? The function accepts
arbitrary keyword args:
https://github.com/apache/beam/blob/640e6c245a89581578da68b26d6e27b55deb6a80/sdks/python/apache_beam/utils/processes.py#L85
Regardless I think `other_arg` is part of what this test is verifying, so I
don't think we should remove it. Let's disable the check instead if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
