andoni-guzman commented on a change in pull request #16541:
URL: https://github.com/apache/beam/pull/16541#discussion_r792878379
##########
File path: sdks/python/apache_beam/transforms/cy_combiners.py
##########
@@ -83,13 +83,14 @@ def extract_output(self):
class SumInt64Accumulator(object):
+ INT64_MAX = 2**_63-1
+ INT64_MIN = -2**_63
def __init__(self):
self.value = 0
def add_input(self, element):
- global INT64_MAX, INT64_MIN # pylint: disable=global-variable-not-assigned
Review comment:
Yes, same case here, I think it's better disable the check instead all
the code for fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
