TheNeuralBit commented on a change in pull request #16541:
URL: https://github.com/apache/beam/pull/16541#discussion_r792930643
##########
File path: sdks/python/apache_beam/utils/processes_test.py
##########
@@ -48,11 +48,9 @@ def test_method_forwarding_not_windows(self, *unused_mocks):
processes.subprocess.check_call.assert_called_once_with(
['subprocess', 'check_call'], shell=False, other_arg=True)
- processes.check_output(['subprocess', 'check_output'],
- shell=False,
- other_arg=True)
Review comment:
Oh I see, sorry about that. It looks like
[`subprocess.run`](https://docs.python.org/3/library/subprocess.html#subprocess.run)
is variadic with `other_popen_kwargs`, but those are likely just passed to
[`subprocess.Popen`](https://docs.python.org/3/library/subprocess.html#subprocess.Popen).
So there is a restricted set of allowed kwargs.
Now I'm thinking what you did originally is a better resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
