andygrove commented on code in PR #346:
URL: https://github.com/apache/datafusion-comet/pull/346#discussion_r1588377152
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -55,8 +55,39 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateFloats, DataTypes.IntegerType)
}
- ignore("cast float to string") {
- castTest(generateFloats, DataTypes.StringType)
+ test("cast double to string") {
+ val testValues = (
+ Seq(
+ 1.0499721536516571e-4,
+ 0.001,
+ 10000000.0,
+ 9999999.0,
+ Float.NegativeInfinity,
+ Float.PositiveInfinity,
+ Float.MinPositiveValue,
+ Double.MinValue,
+ Double.MaxValue,
+ Double.NaN,
+ 0.0,
+ -0.0)
+ ).toDF("a")
+ castTest(testValues, DataTypes.StringType, testAnsiModeThrows = false)
Review Comment:
Also see https://github.com/apache/datafusion-comet/pull/362 which improves
how we handle casts that are not compatible with Spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
