mattharder91 commented on code in PR #346:
URL: https://github.com/apache/datafusion-comet/pull/346#discussion_r1589417244


##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -104,6 +104,14 @@ class CometCastSuite extends CometTestBase with 
AdaptiveSparkPlanHelper {
     castTest(generateBools(), DataTypes.IntegerType)
   }
 
+  test("cast double to string") {
+    castTest(generateDoubles(), DataTypes.StringType)
+  }
+
+  test("cast float to string") {

Review Comment:
   I saw that there were already defined functions for both types so I moved 
them there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to