andygrove commented on code in PR #346:
URL: https://github.com/apache/datafusion-comet/pull/346#discussion_r1589097671


##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -104,6 +104,14 @@ class CometCastSuite extends CometTestBase with 
AdaptiveSparkPlanHelper {
     castTest(generateBools(), DataTypes.IntegerType)
   }
 
+  test("cast double to string") {
+    castTest(generateDoubles(), DataTypes.StringType)
+  }
+
+  test("cast float to string") {

Review Comment:
   ```suggestion
     test("cast FloatType to StringType") {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to