andygrove commented on code in PR #346:
URL: https://github.com/apache/datafusion-comet/pull/346#discussion_r1589096735
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -669,7 +677,7 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
val r = new Random(0)
val values = Seq(
Float.MaxValue,
- Float.MinPositiveValue,
+ // Float.MinPositiveValue,
Float.MinValue,
Review Comment:
Rather than comment it out in the shared `generateFloats` method, I think it
would be better to just have a separate list of values for testing this
specific cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
