andygrove commented on code in PR #346: URL: https://github.com/apache/datafusion-comet/pull/346#discussion_r1589600829
########## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ########## @@ -329,9 +329,22 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { castTest(generateFloats(), DataTypes.createDecimalType(10, 2)) } - ignore("cast FloatType to StringType") { + test("cast FloatType to StringType") { // https://github.com/apache/datafusion-comet/issues/312 Review Comment: We should remove the references to the issue now that we are resolving the issue ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org