vidyasankarv commented on code in PR #383:
URL: https://github.com/apache/datafusion-comet/pull/383#discussion_r1594122726
##########
core/src/execution/datafusion/expressions/cast.rs:
##########
@@ -107,7 +108,23 @@ macro_rules! cast_utf8_to_timestamp {
result
}};
}
-
+macro_rules! cast_utf8_to_date {
Review Comment:
Hi @parthchandra thanks for the review. I am new to rust (and also my first
attempt at an oss contribution).
i was imitating the code from cast_utf8_to_timestamp. removed it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
