vidyasankarv commented on PR #383: URL: https://github.com/apache/datafusion-comet/pull/383#issuecomment-2105729144
hi @parthchandra @andygrove made changes as suggested ported the date parsing logic [from SparkDateTimeUtils](https://github.com/apache/spark/blob/9d79ab42b127d1a12164cec260bfbd69f6da8b74/sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala#L312) This PR does not support fuzzy tests in CometCastSuite for `test Date to String` as Naive Date only supports dates in the below range and the dates generated by fuzzy test for matching with spark are out of this range. ``` /// The minimum possible `Na iveDate` (January 1, 262145 BCE). #[deprecated(since = "0.4.20", note = "Use NaiveDate::MIN instead")] pub const MIN_DATE: NaiveDate = NaiveDate::MIN; /// The maximum possible `NaiveDate` (December 31, 262143 CE). #[deprecated(since = "0.4.20", note = "Use NaiveDate::MAX instead")] pub const MAX_DATE: NaiveDate = NaiveDate::MAX; ``` For Ansi for any format validatoin errors * Try/Legacy mode return - None * Ansi - Err However when all validations pass, for dates that are beyond dates supported by Native Mode all modes return None. Can you please take another look at the PR. thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
