vidyasankarv commented on PR #383: URL: https://github.com/apache/datafusion-comet/pull/383#issuecomment-2100732952
This PR is still in progress. I added support for String to Date32. Do we have to support Date64 as well. * Spark supports dates in the format YYYY and YYYY-MM and DataFusion does not - supported now * Spark supports a trailing T as in 2024-01-01T and DataFusion does not - supported now * DataFusion doesn't throw an exception for invalid inputs in ANSI mode - returns error in ANSI mode if date cant be parsed. Hi @parthchandra @andygrove Can you please review if this is going in the right direction. Questions: * Need some pointers on fuzz tests. If I understand correctly * "-0973250", "-3638-5" fuzz tests in Legacy mode should return values as mentioned https://github.com/apache/datafusion-comet/issues/327 - currently legacy mode returns null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
