andygrove commented on PR #383: URL: https://github.com/apache/datafusion-comet/pull/383#issuecomment-2100947892
> This PR is still in progress. I added support for String to Date32. > > * Spark supports dates in the format YYYY and YYYY-MM and DataFusion does not - supported now > * Spark supports a trailing T as in 2024-01-01T and DataFusion does not - supported now > * DataFusion doesn't throw an exception for invalid inputs in ANSI mode - returns error in ANSI mode if date cant be parsed. > > Hi @parthchandra @andygrove Can you please review if this is going in the right direction. > > Questions: > > * Need some pointers on fuzz tests. If I understand correctly > > * "-0973250", "-3638-5" fuzz tests in Legacy mode should return values as mentioned [Implement Spark-compatible CAST from String to Date #327](https://github.com/apache/datafusion-comet/issues/327) - currently legacy mode returns null. > * Do we have to support Date64 as well ? vidyasankarv Yes, I would say this is going it a good direction based on a very quick review. I will try and find more time tomorrow for a deeper look. To answer your questions: - Yes, ideally we should support the edge cases mentioned in the issue. We could also choose to leave that for a future PR and leave the current support marked as incompatible and provide some documentation on what is not supported (as we have done for string -> timestamp). - No need to support Date64 for this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
