comphead commented on code in PR #331:
URL: https://github.com/apache/datafusion-comet/pull/331#discussion_r1595595448
##########
spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala:
##########
@@ -135,6 +146,97 @@ class CometExpressionCoverageSuite extends CometTestBase
with AdaptiveSparkPlanH
val str = showString(spark.sql("select * from t order by 1"), 1000, 0)
Files.write(Paths.get(rawCoverageFilePath),
str.getBytes(StandardCharsets.UTF_8))
}
+
+ /**
+ * Manual test to calculate Spark builtin expressions coverage support by
the Datafusion
+ * directly
+ *
+ * The test will update files doc/spark_builtin_expr_df_coverage.txt,
+ *
+ * Requires to set DATAFUSIONCLI_PATH env variable to valid path to
datafusion-cli
Review Comment:
It will be added to CI in following PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
