comphead commented on PR #331: URL: https://github.com/apache/datafusion-comet/pull/331#issuecomment-2105096394
> As we add support for more Spark expressions, I can see that it makes sense to see if these expressions are already implemented in DataFusion, but we would still have to implement Spark-specific tests in Comet and then determine if the DataFusion expression is sufficient. If not, we then have to implement our own custom version. Thanks @andygrove for the review. Basically the idea of this test to show how much coverage we currently have in Comet for Spark builtin functions. I supposed it would be interesting to have the following info per each builtin function: - is function supported by Comet? - If its not, is function supported by DataFusion directly or we need to send a PR to DF? - Sometimes function is supported by DF but it gives a wrong result in Comet comparing to Spark Having info we can later generate the coverage .MD dynamically instead of static one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
