advancedxy commented on code in PR #331:
URL: https://github.com/apache/datafusion-comet/pull/331#discussion_r1600060943
##########
spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala:
##########
@@ -61,12 +66,23 @@ class CometExpressionCoverageSuite extends CometTestBase
with AdaptiveSparkPlanH
})
.toMap
+ /**
+ * Manual test to calculate Spark builtin expressions coverage support by
the Comet
+ *
+ * The test will update files doc/spark_builtin_expr_coverage.txt,
+ * doc/spark_builtin_expr_coverage_agg.txt
Review Comment:
it seems like the latest code only generates
spark_builtin_expr_coverage.txt? Maybe these two lines should be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
