andygrove commented on code in PR #383:
URL: https://github.com/apache/datafusion-comet/pull/383#discussion_r1598683954
##########
spark/src/main/scala/org/apache/comet/expressions/CometCast.scala:
##########
@@ -119,7 +119,7 @@ object CometCast {
Unsupported
case DataTypes.DateType =>
// https://github.com/apache/datafusion-comet/issues/327
- Unsupported
+ Compatible()
Review Comment:
Although it seems we are compatible for most common use cases, we are not
100% compatible, so should add a note here.
```suggestion
Compatible(Some("Only supports years between 262143 BC and 262142
AD"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
