viirya commented on code in PR #442:
URL: https://github.com/apache/datafusion-comet/pull/442#discussion_r1605052327
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -698,6 +698,31 @@ class CometSparkSessionExtensions
withInfo(s, Seq(msg1, msg2, msg3).flatten.mkString(","))
s
+ case op: CartesianProductExec
+ if isCometOperatorEnabled(conf, "cross_join") &&
+ op.children.forall(isCometNative) =>
+ val newOp = transform1(op)
+ newOp match {
+ case Some(nativeOp) =>
+ CometCartesianProductExec(
+ nativeOp,
+ op,
+ op.condition,
+ op.left,
+ op.right,
+ SerializedPlan(None))
+ case None =>
+ op
+ }
+
+ case op: CartesianProductExec if !isCometOperatorEnabled(conf,
"cross_join") =>
+ withInfo(op, "Union is not enabled")
+ op
Review Comment:
```suggestion
case op: CartesianProductExec if !isCometOperatorEnabled(conf,
"cross_join") =>
withInfo(op, "Cross join is not enabled")
op
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
