viirya commented on code in PR #442:
URL: https://github.com/apache/datafusion-comet/pull/442#discussion_r1605054299
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -899,6 +899,39 @@ case class CometSortMergeJoinExec(
"join_time" -> SQLMetrics.createNanoTimingMetric(sparkContext, "Total
time for joining"))
}
+case class CometCartesianProductExec(
+ override val nativeOp: Operator,
+ override val originalPlan: SparkPlan,
+ condition: Option[Expression],
+ override val left: SparkPlan,
+ override val right: SparkPlan,
+ override val serializedPlanOpt: SerializedPlan)
+ extends CometBinaryExec {
+
+ override protected def withNewChildrenInternal(
+ newLeft: SparkPlan,
+ newRight: SparkPlan): SparkPlan =
+ this.copy(left = newLeft, right = newRight)
+
+ override def stringArgs: Iterator[Any] = Iterator(condition, left, right)
+
+ override def equals(obj: Any): Boolean = {
+ obj match {
+ case other: CometCartesianProductExec =>
+ this.condition == other.condition &&
+ this.left == other.left &&
+ this.right == other.right &&
+ this.serializedPlanOpt == other.serializedPlanOpt
+ case _ =>
+ false
+ }
+ }
+
+ override def hashCode(): Int = Objects.hashCode(condition, left, right)
+
+ override lazy val metrics: Map[String, SQLMetric] =
+ CometMetricNode.baselineMetrics(sparkContext)
+}
case class CometScanWrapper(override val nativeOp: Operator, override val
originalPlan: SparkPlan)
Review Comment:
```suggestion
}
case class CometScanWrapper(override val nativeOp: Operator, override val
originalPlan: SparkPlan)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
