viirya commented on code in PR #442:
URL: https://github.com/apache/datafusion-comet/pull/442#discussion_r1605056410
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2545,6 +2545,18 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
withInfo(join, "SortMergeJoin is not enabled")
None
+ case join: CartesianProductExec if isCometOperatorEnabled(op.conf,
"cross_join") =>
+ // TODO: Support CartesianProductExec with join condition after new
DataFusion release
+ if (join.condition.isDefined) {
+ withInfo(op, "cross_join with a join condition is not supported")
+ return None
+ }
+ None
Review Comment:
Seems you don't create the protobuf object for CrossJoin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
