kazuyukitanimura commented on code in PR #407: URL: https://github.com/apache/datafusion-comet/pull/407#discussion_r1611036092
########## .github/workflows/pr_build.yml: ########## @@ -76,6 +76,50 @@ jobs: # upload test reports only for java 17 upload-test-reports: ${{ matrix.java_version == '17' }} + linux-test-with-spark4_0: + strategy: + matrix: + os: [ubuntu-latest] + java_version: [17] + test-target: [rust, java] + spark-version: ['4.0'] + is_push_event: + - ${{ github.event_name == 'push' }} + fail-fast: false + name: ${{ matrix.os }}/java ${{ matrix.java_version }}-spark-${{matrix.spark-version}}/${{ matrix.test-target }} + runs-on: ${{ matrix.os }} + container: + image: amd64/rust + steps: + - uses: actions/checkout@v4 + - name: Setup Rust & Java toolchain + uses: ./.github/actions/setup-builder + with: + rust-version: ${{env.RUST_VERSION}} + jdk-version: ${{ matrix.java_version }} + - if: matrix.test-target == 'rust' + name: Rust test steps + uses: ./.github/actions/rust-test + - if: matrix.test-target == 'java' + name: Clone Spark + uses: actions/checkout@v4 + with: + repository: "apache/spark" + path: "apache-spark" + - if: matrix.test-target == 'java' + name: Install Spark + shell: bash + working-directory: ./apache-spark + run: build/mvn install -Phive -Phadoop-cloud -DskipTests Review Comment: Yes, This is only needed for Spark 4.0 because there is no `4.0.0-SNAPSHOT` jar publicly available -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org