kazuyukitanimura commented on code in PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#discussion_r1602283078
##########
spark/src/main/scala/org/apache/spark/sql/comet/DecimalPrecision.scala:
##########
@@ -107,11 +108,4 @@ object DecimalPrecision {
case e => e
}
}
-
- object DecimalExpression {
- def unapply(e: Expression): Option[(Int, Int)] = e.dataType match {
- case t: DecimalType => Some((t.precision, t.scale))
- case _ => None
- }
- }
Review Comment:
Yes, it works. I think this code was copied from Spark 3.5+. This code
should have been in shims to start with.
When we drop Spark 3.x support in the future, we no longer need this object.
We can just directly use `org.apache.spark.sql.types.DecimalExpression`
If keeping the current copy of code is preferred, I can put it back though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
