andygrove commented on issue #3459: URL: https://github.com/apache/datafusion-comet/issues/3459#issuecomment-3874467190
Thanks for the additional info @coderfender. I don't understand why the trait adds value given that there is exactly one implementation per cast and the routing is all static and known at compile time. There is no dynamic dispatch requirement. I am definitely in favor of splitting the current code up into separate files per cast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
