coderfender commented on issue #3459:
URL:
https://github.com/apache/datafusion-comet/issues/3459#issuecomment-3874505402
@andygrove , The sole reason I wanted to add a trait is to enforce contract
and consistency across various cast implementations. For example , some of the
cast implementations which have different signatures
```
fn spark_cast_utf8_to_boolean<OffsetSize>(from: &dyn Array, eval_mode:
EvalMode) -> SparkResult<ArrayRef>
fn cast_string_to_int<OffsetSize>(to_type: &DataType, array: &ArrayRef,
eval_mode: EvalMode) -> SparkResult<ArrayRef>
fn cast_float64_to_decimal128(array: &dyn Array, precision: u8, scale: i8,
eval_mode: EvalMode) -> SparkResult<ArrayRef>
```
But I do agree that we could split this into multiple files as a first step
and perhaps build on that at a later time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
