coderfender commented on issue #3459: URL: https://github.com/apache/datafusion-comet/issues/3459#issuecomment-3874470677
In this approach ,we will be having two phased dispatch to the right function 1. The match arm in the main code (which is now ~ 100 + lines) will be calling the right cast sub module (the length would now be around the number of data types we support) 2. The cast impl guarantees a contract to pass fromtype, to_type , eval mode and other spark options (like session timezone needed for temporal types) and newer implementations , benchmarks and automated test suites ( in future) would benefit from this contract 3. We could potentially avoid the trait and can create a type alias to make it simpler but might be less performant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
