AlyAbdelmoneim commented on code in PR #20253:
URL: https://github.com/apache/datafusion/pull/20253#discussion_r2789467032
##########
datafusion/common/src/config.rs:
##########
@@ -3508,4 +3508,28 @@ mod tests {
"Invalid or Unsupported Configuration: Invalid parquet writer
version: 3.0. Expected one of: 1.0, 2.0"
);
}
+ #[cfg(feature = "parquet")]
+ #[test]
+ fn test_parquet_coerce_int96_validation() {
+ use crate::{config::ConfigOptions, parquet_config::DFTimeUnit};
+
+ let mut config = ConfigOptions::default();
+
+ // Valid values should work
+ config
+ .set("datafusion.execution.parquet.coerce_int96", "ns")
+ .unwrap();
+ assert_eq!(config.execution.parquet.coerce_int96,
Some(DFTimeUnit::NS));
+
+ // ... tests for "us", "ms", "s" ...
Review Comment:
yes I forgot to remove it after writing the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
