AlyAbdelmoneim commented on code in PR #20253:
URL: https://github.com/apache/datafusion/pull/20253#discussion_r2789533835
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -1342,18 +1344,18 @@ mod tests {
let time_units_and_expected = vec![
(
- None, // Same as "ns" time_unit
+ None, // default: None = "ns"
Arc::new(Int64Array::from(vec![
- Some(1704141296123456000), // Reads as nanosecond fine
(note 3 extra 0s)
- Some(1704070800000000000), // Reads as nanosecond fine
(note 3 extra 0s)
- Some(-4852191831933722624), // Cannot be represented with
nanos timestamp (year 9999)
Review Comment:
That’s my mistake the comments were removed unintentionally during test
fixes. I’ll add them back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
