AlyAbdelmoneim commented on code in PR #20253:
URL: https://github.com/apache/datafusion/pull/20253#discussion_r2789515880
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -1342,18 +1344,18 @@ mod tests {
let time_units_and_expected = vec![
(
- None, // Same as "ns" time_unit
+ None, // default: None = "ns"
Review Comment:
yes I'm confused at this part
should I make a None variant in the DFTimeUnit enum ? which I don't think
makes sense, but I don't know what the default should be.
so now the default for coerce_int96 is None (because it was like that before)
but I had to add derive default for the enum itself due to pipeline
requirements, but I don't know what do we actually need here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
