Jefffrey commented on code in PR #20253:
URL: https://github.com/apache/datafusion/pull/20253#discussion_r2797088305
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -1342,18 +1344,18 @@ mod tests {
let time_units_and_expected = vec![
(
- None, // Same as "ns" time_unit
+ None, // default: None = "ns"
Review Comment:
Hmm perhaps I was mislead by these test comments; I'm not certain that
`None` does default to `ns`, especially considering theres some test failures
now 🤔
Might need more investigation before proceeding with this change (of
removing the `Option`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
