jonathanc-n commented on code in PR #20276:
URL: https://github.com/apache/datafusion/pull/20276#discussion_r2796913725
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -248,16 +248,13 @@ impl JoinLeftData {
}
/// Helps to build [`HashJoinExec`].
+///
Review Comment:
We are refactoring this to make it easier for the person who is going to use
it throughout the codebase and make better decisions like adding new fields.
I think the documentation should be geared more to how someone should add a
new field. So explicitly adding something like, "if a field is changed + it is
used to compute properties, `preserve_properties` should be set to false during
reassignment"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
