Re: [PR] Replace ahash with foldhash for faster hashing in datafusion-common [datafusion]

Mon, 16 Mar 2026 06:35:39 -0700 


adriangbot commented on PR #20958:
URL: https://github.com/apache/datafusion/pull/20958#issuecomment-4067714593

   ๐Ÿค– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/20958#issuecomment-4067587376)
   
   <details><summary>Details</summary>
   <p>
   
   ```
   Comparing HEAD and foldhash-hashing
   --------------------
   Benchmark clickbench_extended.json
   --------------------
   
โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query    โ”ƒ                                     HEAD โ”ƒ                      
  foldhash-hashing โ”ƒ        Change โ”ƒ
   
โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ QQuery 0 โ”‚       858.97 / 888.06 ยฑ37.67 / 958.53 ms โ”‚      834.16 / 883.07 
ยฑ34.60 / 912.55 ms โ”‚     no change โ”‚
   โ”‚ QQuery 1 โ”‚        227.74 / 228.63 ยฑ0.76 / 229.71 ms โ”‚       205.48 / 
207.44 ยฑ1.72 / 210.35 ms โ”‚ +1.10x faster โ”‚
   โ”‚ QQuery 2 โ”‚        541.63 / 543.65 ยฑ1.11 / 544.82 ms โ”‚       499.61 / 
502.19 ยฑ1.76 / 504.94 ms โ”‚ +1.08x faster โ”‚
   โ”‚ QQuery 3 โ”‚        334.85 / 336.04 ยฑ1.16 / 337.89 ms โ”‚       316.43 / 
317.67 ยฑ1.02 / 319.48 ms โ”‚ +1.06x faster โ”‚
   โ”‚ QQuery 4 โ”‚       685.99 / 701.63 ยฑ13.70 / 726.71 ms โ”‚      692.46 / 704.06 
ยฑ13.23 / 724.37 ms โ”‚     no change โ”‚
   โ”‚ QQuery 5 โ”‚ 9902.41 / 10285.01 ยฑ255.92 / 10701.69 ms โ”‚ 9724.30 / 9894.96 
ยฑ128.18 / 10104.47 ms โ”‚     no change โ”‚
   โ”‚ QQuery 6 โ”‚     992.41 / 1009.01 ยฑ18.31 / 1043.42 ms โ”‚     999.09 / 1012.97 
ยฑ8.13 / 1021.97 ms โ”‚     no change โ”‚
   โ”‚ QQuery 7 โ”‚        795.02 / 806.15 ยฑ7.80 / 818.08 ms โ”‚      788.41 / 812.15 
ยฑ13.87 / 825.17 ms โ”‚     no change โ”‚
   
โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary               โ”ƒ            โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)               โ”‚ 14798.17ms โ”‚
   โ”‚ Total Time (foldhash-hashing)   โ”‚ 14334.51ms โ”‚
   โ”‚ Average Time (HEAD)             โ”‚  1849.77ms โ”‚
   โ”‚ Average Time (foldhash-hashing) โ”‚  1791.81ms โ”‚
   โ”‚ Queries Faster                  โ”‚          3 โ”‚
   โ”‚ Queries Slower                  โ”‚          0 โ”‚
   โ”‚ Queries with No Change          โ”‚          5 โ”‚
   โ”‚ Queries with Failure            โ”‚          0 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   </p>
   </details>
   
   <details><summary>Resource Usage</summary>
   
   **clickbench_extended โ€” base (merge-base)**
   | Metric | Value |
   |--------|-------|
   | Wall time | 74.6s |
   | Peak memory | 32.6 GiB |
   | Avg memory | 28.0 GiB |
   | CPU user | 737.3s |
   | CPU sys | 24.0s |
   | Disk read | 0 B |
   | Disk write | 22.0 MiB |
   
   **clickbench_extended โ€” branch**
   | Metric | Value |
   |--------|-------|
   | Wall time | 72.3s |
   | Peak memory | 31.7 GiB |
   | Avg memory | 27.2 GiB |
   | CPU user | 714.7s |
   | CPU sys | 23.9s |
   | Disk read | 0 B |
   | Disk write | 76.0 KiB |
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to