Dandandan commented on code in PR #20958: URL: https://github.com/apache/datafusion/pull/20958#discussion_r2941040377
########## datafusion/functions-aggregate/src/hyperloglog.rs: ########## @@ -61,12 +61,7 @@ where /// shared across cluster, this SEED will have to be consistent across all /// parties otherwise we might have corruption. So ideally for later this seed /// shall be part of the serialized form (or stay unchanged across versions). -const SEED: RandomState = RandomState::with_seeds( - 0x885f6cab121d01a3_u64, - 0x71e4379f2976ad8f_u64, - 0xbf30173dd28a8816_u64, - 0x0eaea5d736d733a4_u64, -); +const SEED: foldhash::quality::FixedState = foldhash::quality::FixedState::with_seed(0); Review Comment: There are I think many things that break with new versions just HLL for DataFusion upgrades (protobuf changes being the major one). HLL is one of them, but if we're going to change the hash function not something we can avoid. One could use a versioning strategy (when deploying a new version of DataFusion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
