Dandandan commented on code in PR #20958:
URL: https://github.com/apache/datafusion/pull/20958#discussion_r2941048984
##########
datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs:
##########
@@ -47,8 +47,16 @@ pub struct SeededRandomState {
impl SeededRandomState {
/// Create a new SeededRandomState with the given seeds.
pub const fn with_seeds(k0: u64, k1: u64, k2: u64, k3: u64) -> Self {
+ // Combine 4 seeds into one for foldhash's single-seed API
Review Comment:
Probably would make sense. Probably the usage of `with_seeds` is low enough
that we can just change the signature to use one seed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
